Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0038 "Generic Workspaces" (working title) #290

Closed
wants to merge 1 commit into from
Closed

TEP-0038 "Generic Workspaces" (working title) #290

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 11, 2020

This TEP outlines a problem facing the Workspaces feature in Tekton Pipelines: there are many different
ways that people and companies want to manage Workspaces but Tekton provides only a very narrow set of
supported storage options.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sbwsg
You can assign the PR to them by writing /assign @sbwsg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ghost
Copy link
Author

ghost commented Dec 11, 2020

/kind tep

@tekton-robot tekton-robot added kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2020
@ghost ghost changed the title Propose "Generic Workspaces" TEP TEP-0038 Propose "Generic Workspaces" TEP Dec 13, 2020
@ghost ghost changed the title TEP-0038 Propose "Generic Workspaces" TEP TEP-0038 "Generic Workspaces" (working title) Dec 13, 2020
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2020
Propose "Generic Workspaces" TEP
4c4438b 
This TEP outlines a problem facing the Workspaces feature in Tekton Pipelines: there are many different
ways that people and companies want to manage Workspaces but Tekton provides only a very narrow set of
supported storage options.
@tekton-robot
Copy link
Contributor

@sbwsg: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2020
@ghost ghost closed this Jan 5, 2021
@afrittoli afrittoli mentioned this pull request Mar 10, 2021
Merged
@afrittoli
Copy link
Member

@sbwsg I think this is would be a very interesting feature to have - but I like the bandwidth to implement it at the moment. Would you be interested in getting this merged in proposed state at least, so that when someone has time to work on it we have a problem statement ready?

@ghost
Copy link
Author

ghost commented Mar 10, 2021

/reopen

@tekton-robot
Copy link
Contributor

@sbwsg: Failed to re-open PR: state cannot be changed. The master branch has been deleted.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost
Copy link
Author

ghost commented Mar 10, 2021

Failed to re-open PR: state cannot be changed. The master branch has been deleted.

I'll open a new PR with the same content as this one.

@ghost ghost mentioned this pull request Mar 13, 2021
Merged
tekton-robot pushed a commit that referenced this pull request Apr 1, 2021
@tekton-robot
Propose "Generic Workspaces" TEP
6b2c855 
This TEP outlines a problem facing the Workspaces feature in Tekton Pipelines: there are many different
ways that people and companies want to manage Workspaces but Tekton provides only a very narrow set of
supported storage options.

This was originally prposed in #290
but closed shortly after. Re-opening in response to @afrittoli's
comment here: #290 (comment)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@steveodonovan steveodonovan Awaiting requested review from steveodonovan

Assignees
No one assigned
Labels
kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tekton-robot @afrittoli